cyclone icon indicating copy to clipboard operation
cyclone copied to clipboard

Engine should not call method from cyclone server

Open cd1989 opened this issue 5 years ago • 1 comments

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

Workflow Engine is lower level component of Cyclone, it should not be aware of Cyclone Server logic. So call method of Cyclone server is not allowed.

So this is not allowed:

https://github.com/caicloud/cyclone/blob/master/pkg/workflow/controller/handlers/workflowtrigger/cron_job.go#L19

What happened:

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

cd1989 avatar Jun 13 '19 07:06 cd1989

Should also consider the common package, like https://github.com/caicloud/cyclone/blob/master/pkg/workflow/controller/handlers/workflowtrigger/cron_job.go#L20

supereagle avatar Jun 13 '19 13:06 supereagle