cai can

Results 72 comments of cai can

> Can you update the description with what is the behavior we are actually observing ? The details in jira and PR description does not detail what the issue is,...

> > Can you update the description with what is the behavior we are actually observing ? The details in jira and PR description does not detail what the issue...

Finally, I still choose to implement Iceberg `time travel` by overriding `newScanBuilder`, for the following reasons: 1. Although `SparkIcebergTable` extended `SparkTable`, it still needs to initialize its member variables, such...

> Finally, I still choose to implement Iceberg `time travel` by overriding `newScanBuilder`, for the following reasons: > > 1. Although `SparkIcebergTable` extended `SparkTable`, it still needs to initialize its...

> How about Override `loadTable(Identifier ident, String version)` and `loadTable(Identifier ident, String version)` for `GravitinoIcebergCatalog`? in this way, we still have the problem of initializing the `snapshotId` or `branch` when...

fixed conflict, and could you please help review again if you are free? Thank you @FANNG1

> LGTM, except minor comments comments have been addressed, and could you please help review again? @FANNG1

Hi @FANNG1 will we consider support for spark3.1 and spark3.3 latter? Currently the main versions of spark in XIAOMI are spark3.1 and spark3.3.

> yes, but we planned to do this after the basic feature of the spark-connector is set up. If you're interested, you could do some work. It sounds reasonable. Let's...