yql icon indicating copy to clipboard operation
yql copied to clipboard

Consider migrating to "github.com/antlr/antlr4/runtime/Go/antlr/v4"

Open Rick-xuy opened this issue 2 years ago • 2 comments

It seems that v1 module of github.com/antlr/antlr4/runtime/Go/antlr has been deprecated.
https://github.com/antlr/antlr4/blob/master/runtime/Go/antlr/go.mod

// Deprecated: Please switch to the new v4 module path: github.com/antlr/antlr4/runtime/Go/antlr/v4 - see https://github.com/antlr/antlr4/blob/master/doc/go-target.md
module github.com/antlr/antlr4/runtime/Go/antlr

The new module is github.com/antlr/antlr4/runtime/Go/antlr/v4 and it fit more properly with the idiomatic ways of Go than v1 module. For example, migrating to v4 may reduce the likehood of ambiguous import error related to antlr.
Is there any plan to migrate to github.com/antlr/antlr4/runtime/Go/antlr/v4? If so, this doc may help.

Rick-xuy avatar Feb 19 '23 06:02 Rick-xuy

If there's no breaking changes or just a few changes, I'm willing to do that

caibirdme avatar Feb 19 '23 08:02 caibirdme

Ok, I see. Thanks for your feedback!

Rick-xuy avatar Feb 22 '23 08:02 Rick-xuy