Cesar Gonzalez

Results 60 comments of Cesar Gonzalez

Hm... if the issue described in this PR is actually the case, we likely need to think about this more exhaustively. This would present as a foundational issue in Safari...

@jlf0dev Yeah that's what I'm thinking we'd want to consider, either moving this into the `BrowserApi.sendMessageWithResponse` method or dig a bit further and see if we need to change that...

The performance issues that have been recently reported for the extension relate to the [ShadowDOM fix](https://github.com/bitwarden/clients/pull/6141) that was introduced back in December. This fix introduced an exhaustive approach to handle...

@Celsiusss Hm, yeah the `unshift` to insert the root at the front of the array of elements does explain the performance difference in that SO example. My guess is that...

Need to dig into this a bit more, removing it from "Ready to Review" until then.

> A couple other questions I had during review: > > * It seems like `registerTaskHandler` is marked as returning `void` but was called like `void tss.registerTaskHandler` like it was...

Hm, this was an interesting issue to observe and resolve. So what's happening here is due to behavior that we have tied to an `Enter` keydown event on the input...

Oh one note, if you'd like to mitigate this issue entirely in the meantime you can either set the inline autofill menu to a disabled state or set it to...

@JessicaS11 The fix applies to all extensions and should be available with the release of extension `v2024.4.0`

The "changes" introduced in this ticket appear to have been implemented in https://github.com/bitwarden/clients/pull/7737. As a result, this PR is no longer required and can be closed.