lambadaframework icon indicating copy to clipboard operation
lambadaframework copied to clipboard

Support for application/x-www-form-urlencoded

Open ilndinesh opened this issue 8 years ago • 4 comments

For the requests that come to API gateway with type - "application/x-www-form-urlencoded", I have added a new mapping in a file and applied it during AWS deploy

The other changes are only formatting ones.

ilndinesh avatar Sep 30 '16 13:09 ilndinesh

Hi ilndinesh,

Test aren't passing in org.lambadaframework.jaxrs.JAXRSParserTest.

Regards, Arran

arranubels avatar Oct 03 '16 03:10 arranubels

Hi Ilndinesh,

I have attempted to merge this with my PR in https://github.com/arranubels/lambadaframework/tree/pr4

However there was a part I didn't understand. Please review: https://github.com/bluejeansnet/lambadaframework/compare/x-www-form-urlencoded...arranubels:pr4?expand=1#diff-4d1cba0c8fbb262270c557610751811eR137

Thanks.

Regards, Arran

P.S. Also we need to fix the tests, it would also be a good idea to add some more tests. (I plan to do so too.)

arranubels avatar Oct 03 '16 05:10 arranubels

Hi Arran,

https://github.com/bluejeansnet/lambadaframework/compare/x-www-form-urlencoded...arranubels:pr4?expand=1#diff-4d1cba0c8fbb262270c557610751811eR137

The above diff line is straight forward cast of request body to "String" iff the body is instance of "String". Were you looking explanation for some other diff?

ilndinesh avatar Oct 04 '16 09:10 ilndinesh

Hi Ilndinesh,

Yes. I made another push.. Can you verify I have integrated your code correctly?

I left the thread as is as the position is still a point of interest.

Regards, Arran

arran4 avatar Oct 04 '16 09:10 arran4