treelib icon indicating copy to clipboard operation
treelib copied to clipboard

Fix #139: replace `stdout` with `end` in `show`.

Open ben-e-whitney opened this issue 5 years ago • 2 comments

See #139. This commit reverts the changes made to Treelib.show in 4dde1fd833bb69a5e8375072575c4c091308ad60 and makes the changes proposed in this comment.

ben-e-whitney avatar Feb 04 '20 18:02 ben-e-whitney

Would it be better for me to provide an implementation of contextlib.redirect_stdout or to avoid its use altogether? I don't know the policy on Python 2 compatibility.

ben-e-whitney avatar Feb 04 '20 19:02 ben-e-whitney

@ben-e-whitney thanks for your contribution 👍, I approve converting the reader from string to list, but I still disagree with the use of print, @caesar0301 WDYT?

leonardbinet avatar Feb 22 '20 06:02 leonardbinet