epd-waveshare icon indicating copy to clipboard operation
epd-waveshare copied to clipboard

'color' is not a good name for black and white, rename it to BiColor/BWColor ?

Open caemor opened this issue 2 years ago • 2 comments

See @peckpeck's todo from #132

/// Only for the Black/White-Displays
// TODO : 'color' is not a good name for black and white, rename it to BiColor/BWColor ?
#[derive(Clone, Copy, PartialEq, Eq, Debug)]
pub enum Color {
    /// Black color
    Black,
    /// White color
    White,
}

Peckpecks BWColor might make the most sense for me in describing an enum with black and white, but I'm open to alternatives.

caemor avatar Dec 07 '22 15:12 caemor

Would it be possible to simply use BinaryColor from embedded graphics?

I guess it'a not, additional traits added/etc?

mangelajo avatar Dec 07 '22 20:12 mangelajo

BinaryColor is On or Off, no easy to guess which is black, which is white

peckpeck avatar Dec 08 '22 09:12 peckpeck