mamute icon indicating copy to clipboard operation
mamute copied to clipboard

Add rtl support and Persian translation to mamte #185

Open khajavi opened this issue 9 years ago • 2 comments

refer to this issue I've put all my rtl css properties in custom.css but I don't know how to specialize this file just for Persian locale. Any help?

khajavi avatar Dec 31 '15 13:12 khajavi

I think e8a4056 should add a file called "rtl.css" (instead of naming it custom.css). And the file should only be included whenever a RTL language is active - always including it means that you are switching English and German users also to RTL, whereas they are used to LTR :)

xdarklight avatar Jan 11 '16 00:01 xdarklight

This is awesome contribution, great work, @khajavi!

I agree with @xdarklight, "custom.css" is supposed to be used by mamute users (not by developers) to make small ui changes. I think you should put your css in another file and include it to the html only if an rtf language is being used (maybe adding a feature toggle?)

Can you do it, @khajavi? This is an awesome contribution and it would be great to ship it to master :-)

(notice that you still need to fix the review I left for you at #212)

csokol avatar Feb 03 '16 01:02 csokol