pyCGM icon indicating copy to clipboard operation
pyCGM copied to clipboard

python Convention Gait Model

Results 13 pyCGM issues
Sort by recently updated
recently updated
newest added

Adds new docstrings for refactored code and math behind (although some still need to be updated). Replaces some functions with numpy equivalent.

enhancement
documentation

The marker size, while seemingly always 14mm, should be provided as a measurement with a default of 14 instead.

style

Many functions in pyCGM_Single/pyCGM.py used to take in: `frame`: a dictionary of marker names to positions ``` { "RTIB": np.array([433.97537231, 211.93408203, 273.3008728]), "LTIB": np.array([50.04016495, 235.90718079, 364.32226562]), "RANK": np.array([422.77005005, 217.74053955, 92.86152649]),...

testing

The original test for `pyCGM_Single/pyCGM.py/pelvisJointCenter` expects the z component of the pelvis origin to equal `1032.89349365`. https://github.com/cadop/pyCGM/blob/1750a62ccda8c60171ebe3d45f929c96e00a8300/pyCGM_Single/tests/test_pycgm_axis.py#L966 The new test for pelvisJointCenter (now `pyCGM_Single/pyCGM.py/calc_axis_pelvis`) expects the same value but in...

documentation
testing

### Summary of PR: This PR adds the coding standards to the documentation ![image](https://user-images.githubusercontent.com/61212705/116494242-69cf6300-a86e-11eb-8828-982f65db4bc6.png) ![image](https://user-images.githubusercontent.com/61212705/116494274-7b186f80-a86e-11eb-8573-b14cd6fad8ec.png) ### What issues does this PR close: Documentation ### What files were changed and what...

### Summary of PR: Made appropriate changes to render pycgmStatic Pep 8 compliant. Refactored four functions: - IADCalculation --> iad_calculation - staticCalculationHead --> calculate_head_angle - footJointCenter --> foot_joint_center Also added...

### Summary of PR: This PR refactors pycgmKinetics.py. This PR removes and fixes any functions that can be replaced with the numpy version. ### What issues does this PR close:...

The file pycgmClusters.py contains one function, `calcFramesClusters` which imports a function from clusterCalc.py named `groupInClustDict` that does not exist. On line 15, the function is imported: `from .clusterCalc import targetName,...

bug-light
on hold

Currently marker names are hardcoded everywhere. This makes it hard to load a file that has, for example, a string appended `subject:LFHD`. It would be good to have a function...

enhancement