enhanced whitelist

[cadeyrn]

A whitelist has been added in Bookmarks Organizer 3.0. This includes a link to add bookmarks to the whitelist and the ability to reset the whitelist.

In a future update there will be an enhanced whitelist which lets you remove single entries from the whitelist.

[DuMuT6p]

Hello, Is there a way currently to view the whitelist ?

[cadeyrn]

No. This issue is about implementing the list view and the option to remove entries from the whitelist. You can only clear the whitelist in the add-on's settings in the current version.

[DuMuT6p]

Thank you. This seems like a great feature to have.

[Illegal-Services]

@cadeyrn Hello, I've read the source code from the whitelist and tried to apply a pull request with an export/import settings buttons. While this is possible, and I managed to export successfully, I have noticed that you makes uses of bookmark nodes in order to whitelist. In my opinion this is really wrong because if we change profile and whitelist the exact same bookmark, it will be another node (so it wont have any effect to import the whitelist on another profile). Can you please consider re-writting this feature, and makes uses of the literal string URL instead of the node?

[Illegal-Services]

Apply this whitelist change will be the first step to resolve any of the current whitelist feature requests: https://github.com/cadeyrn/bookmarks-organizer/issues/96: enhanced whitelist https://github.com/cadeyrn/bookmarks-organizer/issues/115: [request] whitelisting webpage domains before scan https://github.com/cadeyrn/bookmarks-organizer/issues/165: How to list all currently whitelisted bookmarks? https://github.com/cadeyrn/bookmarks-organizer/issues/182: [FEATURE REQUEST/QUESTION] Whitelisting source or destination address? https://github.com/cadeyrn/bookmarks-organizer/issues/202: [FEATURE REQUEST] - Add an option to export and import whitelist (settings) https://github.com/cadeyrn/bookmarks-organizer/issues/213: Problems with Facebook Bookmarks - Declared as "dead" - Allow whitelisting of domains https://github.com/cadeyrn/bookmarks-organizer/issues/217: Whitelist managing

[cadeyrn]

There are some things to consider:

• Bookmarks Organizer always operated on the bookmark level. Does it really matches the user expectations if the whitelist does not operate on the bookmark level?
• URLs can change over time. What would happen if the user changes the URL of the bookmark? Should it be removed from the whitelist or should the whitelist be modified if a bookmark change happens?
• You can have more than one bookmark for the same URL. Do we really want to lose the ability to put one bookmark on the whitelist, but not the other one?
• URLs are much longer than IDs, so much more data has to be saved. Does it have any meaningful impact for the storage size or the performance if many items are on the whitelist?

[Illegal-Services]

Personally on my own project, that is in Python, I whitelist using:

[{HTTP_Code}] {Source URL} > [{HTTP_Code}] {Destination URL} [301] https://www.google.com/ > [200] https://www.youtube.com/

(As many redirects as there are 👆)

And for "error" bookmarks I use: [{HTTP_code}] {URL} [404] https://www.google.com

Exactly has you mentioned, it contains downsides as well.

🤷

[Illegal-Services]

I also make uses of regex in my whitelist, which is useful for certain websites who their URL changes every x time.