Cade Daniel
Cade Daniel
`//python/ray/tests:test_multiprocessing test_callbacks` hangs for both grpcio==1.43.0 and 1.48.1 so I assume it has to do with my environment? Is there a way I can replicate the BK environment and iterate...
> Thanks for working on this! Just to understand - besides the missing timeout in the tests, there were no other changes necessary to support grpc 1.48? Yep! I believe...
I'm increasing the timeouts on all of the tests that I've seen become flaky on Windows because of this change. ``` test_reference_counting test_multiprocessing test_asyncio test_queue test_runtime_env_working_dir_3 ```
I have a lint fix but waiting for windows builds to succeed before I push
Hmm I'm doubtful they're the same since `unexpected end of data` is pretty telling, discussing more here https://discuss.ray.io/t/entire-ray-cluster-dying-unexpectedly/7977
Will take another pass tomorrow
I passed through the code. I think this PR is mixing the abstraction boundaries too much. I wrote out some pseudocode for a better way of using the existing APIs...
OK, will take a look thurs or fri this week
> @cadedaniel Hi cade, i think it's ready for another round of review. One small point is currently the preemption_mode parameter in _preempt() are default to RECOMPUTE and never be...
The e2e test has good coverage but it's bad at verifying lower level properties in edge cases. Eg that swapped block ids are correct. We want to have coverage of...