feat(chart): add service.yaml

[sanadhis]

What problem: I need to install caddy to K8s, but I don't need external load balancer.

Why this is a solution: By adding this loadBalancer.enabled value, which default to true, we can make the load balancer optional. This is also to ensure smart transition to service.yaml for already-existing user of this helm chart.

[mavimo]

@sanadhis thanks for your contribution!

May I ask to include the new keys in the values.schema.json file?

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 20.75%. Comparing base (02b2c20) to head (427db65). Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   20.75%   20.75%           
=======================================
  Files          30       30           
  Lines        1378     1378           
=======================================
  Hits          286      286           
  Misses       1090     1090           
  Partials        2        2           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[sanadhis]

@sanadhis thanks for your contribution!

May I ask to include the new keys in the values.schema.json file?

Thanks for your feedback! Yes, updated

[mavimo]

@sanadhis internalTrafficPolicy and externalTrafficPolicy have different behaviour (internal for traffic routing exteral for preserving client IP) I'm not sure about the last changes you included, can you give us some context? 🤔

Thanks!

[sanadhis]

@sanadhis internalTrafficPolicy and externalTrafficPolicy have different behaviour (internal for traffic routing exteral for preserving client IP) I'm not sure about the last changes you included, can you give us some context? 🤔

Thanks!

Hey, yes I am well aware, I was thinking to keep things simple. Sure I can add it back. I'll do some refactor also since we provide default value anyway. I am also squashing my commits

[sanadhis]

@mavimo can we merge this one please? Thanks!

[mavimo]

@sanadhis I'll try to run the validation and merge ASAP

I'm planning to release a new version as soon as this is merged.

[sanadhis]

Hi @mavimo can we merge this please? I have seen few releases have happened since.

Otherwise if you're not convinced with the change we can close it. Though I would say I would prefer not to create my own fork.

[sanadhis]

Thanks @mavimo !!