caddy icon indicating copy to clipboard operation
caddy copied to clipboard

logging: fix multiple regexp filters on same field (fixes #7049)

Open s2010 opened this issue 5 months ago • 4 comments

Solution

  • Added MultiRegexpFilter to handle multiple regex operations on same field
  • Enhanced FilterEncoder to automatically merge multiple regexp filters
  • Maintained full backward compatibility
  • Added security limits (max 50 operations, 1000 char patterns, 1MB input)

Changes

  • modules/logging/filters.go: Added MultiRegexpFilter with security validation
  • modules/logging/filterencoder.go: Enhanced parsing with automatic merging
  • modules/logging/filters_test.go: Added comprehensive tests
  • Added integration test

s2010 avatar Jun 11 '25 20:06 s2010

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 11 '25 20:06 CLAassistant

Nice, looks good! Don't forget to sign the CLA

francislavoie avatar Jun 11 '25 20:06 francislavoie

I don't think I'm able to push to the branch, but if you sync up again the CI might pass.

mholt avatar Jun 13 '25 15:06 mholt

Hi @mholt I've resolved all the CI/CD pipeline issues that were preventing this PR from passing and synced up the branch.

s2010 avatar Jun 14 '25 11:06 s2010