caddyserver
Add Otel Trace client interactions
Should be okay now for the most part it works well see https://github.com/trajano/google-fonts-proxy-docker/pull/7#issuecomment-2273891255 for a screenshot
But there's one context.TODO() line I am not sure which context to pass in at that point.
I kinda want http.getconn to put the net.hostname as the span title so you don't have to drill down to see the value, but I can't seem to get that working yet.
Hey, sorry for the lack of response. I'm not really savvy with OTel, so I want to leave this for someone else to review.
@francislavoie Do you know who might be the best reviewer for this?
Odd the lint errors I am getting appear to be from places I didn't touch.
They appeared with the new Go version. I'm fixing them locally, then you can merge once pushed and merged from my side.
@mohammed90 do you have a branch pushed I just merge from?
Patience is good
@mohammed90 do you have a branch pushed I just merge from?
Patience is good
Confirmed to be false-positive in gosec bound-check: https://github.com/securego/gosec/pull/1189.
Ignore the lint failure for now.
So we need a commit to adjust the rules first so my PR will be able to merge it.
Odd I just wanted to sync the branches. I think I just lost all my OTEL work. @mohammed90
Nothing should be lost in Git. Checkout the commit 10fe43b107827263d32457d6dff91edb5e0f9c45 and push it to the branch.
It's k I'm just going to leave it closed. It's been up for a year and looking through the history I'll leave it to someone else to try to do this. I'm just going to run it off my fork if anyone is interested.
I'm just glad I got it working again