caddy icon indicating copy to clipboard operation
caddy copied to clipboard

Implemented the zerossl API to issue ssl certificates

Open armadi1809 opened this issue 1 year ago • 6 comments

Closes #6064

armadi1809 avatar Jan 28 '24 02:01 armadi1809

@mholt This is my initial attempt to implement the ZeroSSL API to issue new certs. I am sure it will require further adjustments so any feedback here would be great 😅 Also, what do you think is the best/easiest way to test this thoroughly and make sure it's working as intended?

armadi1809 avatar Jan 28 '24 02:01 armadi1809

Just circling back, sorry again for the delay.

I did a quick scan and the overall approach looks right: use ACME unless the API is explicitly enabled. I still need to read through the API code and the API docs and see how that goes, and test it out. I have an account with ZeroSSL that will let me test this, so maybe I'll just do that (unless you'd really like to -- in that case I can request you get special access to be able to do so).

mholt avatar Jan 31 '24 05:01 mholt

That would work, you can test it and I'll take it back from there based on your feedback. Thank you!

armadi1809 avatar Jan 31 '24 05:01 armadi1809

(Still on my list! Sorry!)

mholt avatar Feb 12 '24 23:02 mholt

I experiencing this error on production. Is there any workaround?

Should I replace caddy with letsencrypt + nginx or better wait for this update?

gustawdaniel avatar Feb 13 '24 11:02 gustawdaniel

What issue @gustawdaniel? This is a new feature.

Please open a topic on the forums if you need help https://caddy.community

francislavoie avatar Feb 13 '24 12:02 francislavoie

@armadi1809 Hey Aziz, I went ahead and built on your work in https://github.com/caddyserver/zerossl -- and from there I'll integrate the API use in Caddy/CertMagic :)

Thanks for the kickstart!! I gave you credit in the commit.

mholt avatar Mar 05 '24 17:03 mholt

Next steps will be to probably move the ZeroSSLIssuer into CertMagic, so CM users can also use ZeroSSL easily. Then to make the ZeroSSLIssuer in Caddy a simple wrapper over the CM one, kind of like ACMEIssuer is.

mholt avatar Mar 05 '24 17:03 mholt