caddy icon indicating copy to clipboard operation
caddy copied to clipboard

Added modular ca providers the tls config of the reverse proxy http transport module.

Open armadi1809 opened this issue 1 year ago • 3 comments

Closes #6063

armadi1809 avatar Jan 26 '24 05:01 armadi1809

Looks like the failed test is just a server timeout.

armadi1809 avatar Jan 26 '24 05:01 armadi1809

I just added the "deprecated" comments to RootCAPool and RootCAPEMFiles fields as well as a deprecation warning log when those are used.

armadi1809 avatar Jan 27 '24 17:01 armadi1809

No worries at all Mohammed! Thank you for your feedback. I implemented the caddy file support and added both caddy file integration tests as well as tests for the (h *HTTPTransport) UnmarshalCaddyfile function. Please let me know if anything else is still needed here. Thanks again!

armadi1809 avatar Jan 28 '24 22:01 armadi1809

@mohammed90 Anything you can think of we need to change for this?

mholt avatar Mar 06 '24 22:03 mholt

@mohammed90 I think all your feedback items have been resolved Thanks for reviewing!

armadi1809 avatar Mar 12 '24 04:03 armadi1809