haskell-release-action icon indicating copy to clipboard operation
haskell-release-action copied to clipboard

Re-apply the git tag after bumping the cabal version

Open sandydoo opened this issue 2 years ago • 4 comments

Tested against https://github.com/sandydoo/haskell-release-action-test.

sandydoo avatar May 22 '23 17:05 sandydoo

I'm not sure how I feel about this 😂

sandydoo avatar May 22 '23 18:05 sandydoo

The person pushing the original tag will have issues pulling in the release if the two tags match. The release could be prefixed, but we'll still end up littering the repo with the original tags. 🤷

Maybe it makes sense to explore a different release approach? Maybe pushing to release branch?

sandydoo avatar May 22 '23 19:05 sandydoo

If we use different tag names for the tag that triggers CI vs the final release tag, then we should _not delete the trigger tag. Deleting it will re-run the CI if it's pushed again.

sandydoo avatar May 22 '23 19:05 sandydoo

Ideally we'd use release/v* branch by default (configurable) and split the action into two bits:

a) bumping cabal inside the branch b) doing hackage upload and tag once it's merged

domenkozar avatar May 24 '23 18:05 domenkozar