devenv icon indicating copy to clipboard operation
devenv copied to clipboard

`cli` test should use local devenv module

Open ento opened this issue 1 year ago • 2 comments

One change from #1421 that wasn't part of #1427. (Both PRs addressed the same bug in devenv container build shell, and the latter was merged.)

While working on #1421, I noticed tests/cli, which runs devenv container build shell as part of its test script, wouldn't fail as it should've when the bug was present. I believe it's because tests/cli/devenv.yaml doesn't override the devenv input like devenv-run-tests or tests/clean/devenv.yaml does.

https://github.com/cachix/devenv/blob/9ff4999b3555936942ee84f6c11fbb103ca52b3e/devenv-run-tests/src/main.rs#L80-L85

https://github.com/cachix/devenv/blob/9ff4999b3555936942ee84f6c11fbb103ca52b3e/tests/clean/devenv.yaml#L1-L3

ento avatar Sep 09 '24 20:09 ento

Thanks for catching this one! I wonder if there's a better design to make sure devenv cli always uses the override in all commands.

domenkozar avatar Sep 10 '24 09:09 domenkozar

I'm going to let @sandydoo chip in next week if we could expose devenv on $PATH with correct devenv input override.

domenkozar avatar Sep 10 '24 20:09 domenkozar

https://github.com/cachix/devenv/commit/10ab16635312bc59aac940e9faef5936cae0bc6f

domenkozar avatar May 15 '25 09:05 domenkozar