devenv icon indicating copy to clipboard operation
devenv copied to clipboard

feat: add flag to disable containers tooling (#1367)

Open blackheaven opened this issue 1 year ago • 10 comments

blackheaven avatar Aug 10 '24 17:08 blackheaven

Nice! Any chance to separate styling changes from the behavior change?

domenkozar avatar Aug 11 '24 10:08 domenkozar

Actually it's enforced by the pre-commit hook.

I can try to make a first commit with only formatting, would it be okay?

blackheaven avatar Aug 11 '24 10:08 blackheaven

That would be perfect, thank you!

domenkozar avatar Aug 11 '24 14:08 domenkozar

done :)

blackheaven avatar Aug 11 '24 15:08 blackheaven

Actually it's enforced by the pre-commit hook.

@blackheaven, are you sure it's not your editor's tooling doing the formatting? This doesn't look like nixpkgs-fmt to me. If it really is, I'll have to investigate why our hooks are broken.

sandydoo avatar Aug 12 '24 09:08 sandydoo

@blackheaven, are you sure it's not your editor's tooling doing the formatting? This doesn't look like nixpkgs-fmt to me. If it really is, I'll have to investigate why our hooks are broken.

I think my language server formatted twice, anyway, it's fixed now.

blackheaven avatar Aug 12 '24 21:08 blackheaven

The main reason why I haven't merged this yet is because I'm not convinced what the API should look like.

Maybe we should add something like containers.<name>.contents = []; that would imply to build the container from scratch?

domenkozar avatar Aug 13 '24 16:08 domenkozar

@Mic92 Thank you so much!

blackheaven avatar Aug 15 '24 13:08 blackheaven

Maybe we should add something like containers.<name>.contents = []; that would imply to build the container from scratch?

Should we check that for other parameters? (i.e. perms, etc.)

blackheaven avatar Aug 15 '24 13:08 blackheaven

@sandydoo can you check this one? :eyes:

domenkozar avatar Nov 30 '24 10:11 domenkozar

Closing as outdated.

domenkozar avatar Nov 25 '25 17:11 domenkozar