devenv
devenv copied to clipboard
feat: add flag to disable containers tooling (#1367)
Nice! Any chance to separate styling changes from the behavior change?
Actually it's enforced by the pre-commit hook.
I can try to make a first commit with only formatting, would it be okay?
That would be perfect, thank you!
done :)
Actually it's enforced by the pre-commit hook.
@blackheaven, are you sure it's not your editor's tooling doing the formatting? This doesn't look like nixpkgs-fmt to me. If it really is, I'll have to investigate why our hooks are broken.
@blackheaven, are you sure it's not your editor's tooling doing the formatting? This doesn't look like
nixpkgs-fmtto me. If it really is, I'll have to investigate why our hooks are broken.
I think my language server formatted twice, anyway, it's fixed now.
The main reason why I haven't merged this yet is because I'm not convinced what the API should look like.
Maybe we should add something like containers.<name>.contents = []; that would imply to build the container from scratch?
@Mic92 Thank you so much!
Maybe we should add something like
containers.<name>.contents = [];that would imply to build the container from scratch?
Should we check that for other parameters? (i.e. perms, etc.)
@sandydoo can you check this one? :eyes:
Closing as outdated.