devenv icon indicating copy to clipboard operation
devenv copied to clipboard

Refactor/git hooks - Rename pre-commit-hooks package to git-hooks package

Open UseTheFork opened this issue 1 year ago • 2 comments

The upstream package has been renamed so this is a quick refractor to update that.

Issues Addressed:

  • Closes #1066

UseTheFork avatar Jul 05 '24 15:07 UseTheFork

This needs a rename for the nixos option and redirect for the docs url

domenkozar avatar Jul 08 '24 16:07 domenkozar

This needs a rename for the nixos option and redirect for the docs url

So I was going to ask you about this. I didn't want it to be a breaking change by renaming the base option from pre-commit.hooks to git-hooks.pre-commit.

since mkRenamedOptionModule doesn't work in bulk with submodules and the modules coming from pre commit are dynamic anyone that pulls the latest release would have to rename immediately or an error would be thrown.

The other option would be to add an assertion and be explicit about the name change there. Let me know and I will make the changes.

UseTheFork avatar Jul 08 '24 16:07 UseTheFork

done by @sandydoo

domenkozar avatar Nov 20 '24 16:11 domenkozar