cachho

Results 126 comments of cachho

> Great PR! I left some comments Hey, thanks for taking your time and the one fix. I will remove the type check for list, since it's not required anymore....

@candidosales I get a linting error for the typing (I'm using Python 3.8.10). And it's also throwing an error when I run it. ``` def generate_prompt(self, input_query: str, contexts: list[str]):...

> In my opinion, it would be beneficial to incorporate infer types in all methods I agree, once again the only problem with it in this PR is that we...

resolved the merge conflicts.

adjusted to new config

example: ```python import os from embedchain import App from embedchain.config import AddConfig, QueryConfig naval_chat_bot = App() add_config = AddConfig() # Currently no options naval_chat_bot.add("youtube_video", "https://www.youtube.com/watch?v=3qHkcs3kG44", add_config) naval_chat_bot.add("pdf_file", "https://navalmanack.s3.amazonaws.com/Eric-Jorgenson_The-Almanack-of-Naval-Ravikant_Final.pdf", add_config) naval_chat_bot.add("web_page",...

@taranjeet changed readme text to `number of documents to be retrieved as context` as asked for in #163

du to the custom prompt, the idea of changing the prompt based on plural and singular numbers was ditched. I think that's okay.

Yes, please add an option to save the added playlists to the filesystem.

I deployed my project to production with this issue, here's what I've learned. It covers a case where you have another page at root, and how to deal with it...