kramdown-rfc icon indicating copy to clipboard operation
kramdown-rfc copied to clipboard

Run svgcheck with -N

Open larseggert opened this issue 4 years ago • 9 comments

svgcheck seems to sometimes die when the network is not available, see https://github.com/larseggert/i-d-toolchain/runs/1969937318?check_suite_focus=true#step:4:51

I wonder if it would make sense to run it with -N aka --no-network?

(I was surprised it needed to make network connections to begin with.)

larseggert avatar Feb 24 '21 12:02 larseggert

So it turns out that -N prevents any network requests, but that basically makes svgcheck fail for me, because it then says it can't retrieve http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd anymore.

Could you remove the -N again?

larseggert avatar Apr 19 '21 12:04 larseggert

Weird, I just used svgcheck with 1.4.2 and it worked for me. What was the input?

cabo avatar Apr 19 '21 12:04 cabo

(I'm using svgcheck 0.6.0)

cabo avatar Apr 19 '21 12:04 cabo

I only see this when I run inside GitHub Actions. I wonder if they have a weird network setup.

larseggert avatar Apr 19 '21 12:04 larseggert

For example, this fails, and has been failing since you made the change 13 days ago: https://github.com/larseggert/i-d-toolchain/runs/2380758454?check_suite_focus=true#step:6:36

larseggert avatar Apr 19 '21 13:04 larseggert

I notice that I have svg11.dtd in my ~/.cache/xml2rfc Renaming it doesn't cause the problem for my current I-D, though. It seems that your test fails at *** could not create svg for "\nmsc {\n a [label=... It also seems that the download to cache of svg11.dtd and all its dependencies was initiated when I processed an mscgen file a couple of months ago.

cabo avatar Apr 19 '21 13:04 cabo

Yeah, I don't really know what svgcheck is doing. All I noticed is that the issue doesn't happen when I remove the -N again.

larseggert avatar Apr 19 '21 13:04 larseggert

Yep, mscgen spits out

<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN"
 "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">

and svgcheck then wants to read that (I moved my cached copy away).

cabo avatar Apr 19 '21 13:04 cabo

I pushed a 1.4.3 without -N A better fix would be to remove the DOCTYPE from the mscgen output, but that seems a larger effort.

cabo avatar Apr 19 '21 13:04 cabo