python-consul icon indicating copy to clipboard operation
python-consul copied to clipboard
verified publisher icon cablehead

Add new acl system

Open Dudesons opened this issue 6 years ago • 2 comments

Hi @cablehead,

It concerns new acl system for consul 1.4 and 1.5

In this pr I had the possibility to manage the following parts of the ACL api:

  • https://www.consul.io/api/acl/tokens.html
  • https://www.consul.io/api/acl/policies.html
  • https://www.consul.io/api/acl/roles.html
  • https://www.consul.io/api/acl/auth-methods.html
  • https://www.consul.io/api/acl/binding-rules.html

Dudesons avatar May 15 '19 12:05 Dudesons

@abarbare do you have some other request changes / reviews ?

Dudesons avatar Jan 27 '20 16:01 Dudesons

@Dudesons Actually yes, the args_to_payload function doesn't fit my requirements as it will push each parameters as query string parameters. However, the Consul API is waiting those parameters as body parameters so it won't work.

I did a patch on my fork but I'm not 100% satisfied at this time of this solution as it mixes query string and body parameters but it works https://github.com/abarbare/python-consul/pull/1/files

abarbare avatar Jan 27 '20 16:01 abarbare