python-consul icon indicating copy to clipboard operation
python-consul copied to clipboard

Added node parameter to data in Catalog register

Open hreidar opened this issue 7 years ago • 3 comments

This is done so the API properly passes node_meta data to Consul. PR #222 did not fix this issue. Consul appears to want node_meta in the data body not params.

I am not sure about the exact mechanisms behind the consul server. Should we remove the node_meta addition to params and only add it to the data body?

hreidar avatar Nov 29 '18 13:11 hreidar

Not sure why the tests are failing, just added one line ;-)

hreidar avatar Nov 29 '18 13:11 hreidar

I'd love to see this fixed and merged, this fixed my issue and let me update NodeMeta and start testing with consul-esm

tfhartmann avatar Dec 19 '18 19:12 tfhartmann

No interest in fixing this? I don't believe the checks are failing because of my code additions.

hreidar avatar Dec 06 '19 13:12 hreidar