python-consul icon indicating copy to clipboard operation
python-consul copied to clipboard
verified publisher icon cablehead

fix txn token,dc and consistency

Open amuhametov opened this issue 7 years ago • 7 comments

fixes #148

amuhametov avatar Aug 02 '18 13:08 amuhametov

added auto-decode for values

amuhametov avatar Aug 03 '18 09:08 amuhametov

Hi @amuhametov, Thank you for your PR! I will review your PR soon. Stay tuned!

matusvalo avatar Aug 14 '18 21:08 matusvalo

@amuhametov, I have added comments to your PR. In short:

  • doc strings needs to be updated
  • I suggest to hide encoding/decoding into method logic. After this encoding and decoding are transparent to user similarly to current KV put() method logic. This can break API backward compatibility. If nobody is against I prefer to move in this direction.
  • migrate params from dict format to list format

matusvalo avatar Aug 27 '18 14:08 matusvalo

@matusvalo are you sure we should break the API? I think it is wrong to annoy users. Rolled back API change.

amuhametov avatar Oct 08 '18 18:10 amuhametov

@cablehead @matusvalo guys?

amuhametov avatar Oct 23 '18 10:10 amuhametov

ping

amuhametov avatar May 20 '19 12:05 amuhametov

#225 @amuhametov welcome to here

ping

poppyred avatar Oct 10 '19 11:10 poppyred