python-consul icon indicating copy to clipboard operation
python-consul copied to clipboard
verified publisher icon cablehead

Redundant wait and index params in event.list() API

Open matusvalo opened this issue 7 years ago • 2 comments

In Event.list method we are creating wait and index parameters:

https://github.com/cablehead/python-consul/blob/41b7c8c4b6caf7d32b2a073fd74fdc631de09e1a/consul/base.py#L452-L460

But in documentation no such parameters are present: https://www.consul.io/api/event.html#list-events

Is this something coming from older versions of Consul? I haven't found any mention about it. Or is this bug and we need to remove this params? Can anyone help?

matusvalo avatar Jul 13 '18 10:07 matusvalo

@matusvalo look here

wellcom to python-consul2,This is my ongoing maintenance version

poppyred avatar Oct 29 '19 05:10 poppyred

@matusvalo and https://github.com/hashicorp/consul/blob/66d138f35e2cc5548412a55362a7bcedbe198888/api/event.go#L69 https://github.com/hashicorp/consul/blob/66d138f35e2cc5548412a55362a7bcedbe198888/agent/event_endpoint.go#L74 https://github.com/hashicorp/consul/blob/66d138f35e2cc5548412a55362a7bcedbe198888/api/api.go#L631

poppyred avatar Oct 29 '19 05:10 poppyred