baritone icon indicating copy to clipboard operation
baritone copied to clipboard

Port to 1.21.5

Open Tjkieff opened this issue 9 months ago • 19 comments

Hey could you update the mod to 1.21.5 for fabric, I could really like to use it to build structures for me on a private SMP server i play on. Thanks, keep up the good work!

Tjkieff avatar Apr 04 '25 03:04 Tjkieff

while there isnt a 1.21.5 version on the releases page you can find 1.21.5 builds on the actions page just beware of the possibility of it being buggy since it isnt a proper release

https://github.com/cabaletta/baritone/actions https://github.com/cabaletta/baritone/actions/runs/14159760100

ThePlainBagel avatar Apr 04 '25 03:04 ThePlainBagel

Cool thanks!

Tjkieff avatar Apr 04 '25 04:04 Tjkieff

Specifically, that CI run comes from https://github.com/cabaletta/baritone/pull/4692, an unmerged draft pull request with a lot of boxes yet to be ticked.

ZacSharp avatar Apr 04 '25 16:04 ZacSharp

how do you get a usable jar from the recent builds

Jurassicboy2710 avatar Apr 05 '25 19:04 Jurassicboy2710

You go to the appropriate CI run (from this list, note that this includes pull request builds), download the "Artifacts" file (you must be logged in and the link expires after 3 months), take the jar you want from out of the zip you just downloaded.

Going from a pull request to its latest CI run is also possible by clicking on "Java CI with Gradle / build (pull_request)" (might be hidden in "successful checks") at the bottom and then "Summary" at the top left.

ZacSharp avatar Apr 06 '25 02:04 ZacSharp

or, you can also use viafabplus

guamothy avatar Apr 13 '25 20:04 guamothy

I installed the latest 1.21.5 test build but pathing is not working in overworld.

Logs in chat: Image

Logs in latest.log:

Image

wujinjun-MC avatar Apr 17 '25 10:04 wujinjun-MC

What are your modified settings? (including the values)

ZacSharp avatar Apr 17 '25 11:04 ZacSharp

Only modified randomLooking and randomLooking113 to 0.0

wujinjun-MC avatar Apr 17 '25 12:04 wujinjun-MC

Hm, suspected you had some cost-affecting setting with a nonsensical value (like negative break penalty). Are you using any mods?

ZacSharp avatar Apr 17 '25 13:04 ZacSharp

Use mods including baritone fabric-api sodium iris - failed Image

Only enable baritone-standalone-fabric-1.8.3-51-ga7f87dff.jar and fabric-api-0.120.0+1.21.5.jar - failed

Video:

https://github.com/user-attachments/assets/1758e11e-8d6e-49df-8d3c-386d88c6d4c8

wujinjun-MC avatar Apr 17 '25 14:04 wujinjun-MC

Ok, since this conversation will probably go on a bit more, can you please open a new bug report for this and we continue there?

ZacSharp avatar Apr 17 '25 16:04 ZacSharp

Can you please try again (without other mods) using a build made from https://github.com/ZacSharp/baritone/commit/886dcf44a10f64388a405e45d2278df3b176a5f5? You can add a screenshot of the location it prints in the error message to the new issue.

ZacSharp avatar Apr 17 '25 23:04 ZacSharp

ZacSharp @ 886dcf4 (Action Build #1569) is for 1.19.4, not for 1.21.5

Image

English version:

Image

wujinjun-MC avatar Apr 18 '25 01:04 wujinjun-MC

Fixed by adding actionCost = -actionCost; in src/main/java/baritone/pathing/calc/AStarPathFinder.java

if (actionCost <= 0 || Double.isNaN(actionCost)) {
                    actionCost = -actionCost;
                    // throw new IllegalStateException(moves + " calculated implausible cost " + actionCost);
                }

Action Build: wujinjun-MC/baritone_1.21.5/Actions/#9

wujinjun-MC avatar Apr 18 '25 02:04 wujinjun-MC

ZacSharp @ 886dcf4 (Action Build #1569) is for 1.19.4, not for 1.21.5

whops. I thought I did that on 1.21.5. Either way, what I'm interested in is not the coordinates themselves but the blocks around them.

Fixed by adding actionCost = -actionCost; in src/main/java/baritone/pathing/calc/AStarPathFinder.java

No, that is very unlikely to be a fix. If a movement has negative cost then something went wrong and pretending nothing happened will not change that.

Also can you please open a new issue for this?

ZacSharp avatar Apr 18 '25 14:04 ZacSharp

Also can you please open a new issue for this?

#4714

I tested 1.21.3 and the exception also exists on that version.

wujinjun-MC avatar Apr 19 '25 05:04 wujinjun-MC

W mod

itsYoBoyJamal avatar Apr 22 '25 03:04 itsYoBoyJamal