baritone icon indicating copy to clipboard operation
baritone copied to clipboard

Baritone crashes with SongPlayer installed

Open buhhhhg opened this issue 10 months ago • 5 comments

Some information

Operating system: Windows 10 22H2 (OS Build 19045.5555) Java version: 21.0.3 Minecraft version: Fabric 1.21.4 Baritone version: 1.21.4-SNAPSHOT (Meteor Client fork) (attempted to get version in-game, returned Null version (this is normal in a dev environment) ) Other mods (if used): modlist.txt

Exception, error or logs

latest.log

How to reproduce

  • Download Baritone from https://meteorclient.com
  • Download SongPlayer (https://modrinth.com/mod/songplayer)
  • Add both mods to the mods folder / mods list
  • Run Minecraft 1.21.4

Modified settings

settings.txt

Final checklist

  • [x] I know how to properly use check boxes
  • [x] I have included the version of Minecraft I'm running, baritone's version and forge mods (if used).
  • [x] I have included logs, exceptions and / or steps to reproduce the issue.
  • [x] I have not used any OwO's or UwU's in this issue.

buhhhhg avatar Mar 06 '25 23:03 buhhhhg

Looks like a mixin redirect conflict. Apparently both are redirecting the same field access in the same method (getting Abilities.mayfly in LocalPlayer.aiStep).

ZacSharp avatar Mar 08 '25 23:03 ZacSharp

could there be any fix for this?

buhhhhg avatar Mar 21 '25 07:03 buhhhhg

I opened a pull request to fix this in SongPlayer.

Ideally Baritone would also use @Redirect less, but I didn't try switching to ModifyExpressionValue/WrapOperation yet because using MixinExtras on LexForge or Launchwrapper requires bundling it ourselves.

ZacSharp avatar Mar 29 '25 03:03 ZacSharp

thank you!

buhhhhg avatar Apr 02 '25 14:04 buhhhhg

i made a fork of your repository and used Github Actions - mod works

Image

buhhhhg avatar Apr 07 '25 23:04 buhhhhg