baritone icon indicating copy to clipboard operation
baritone copied to clipboard

resolves issue #6

Open rycbar0 opened this issue 2 years ago • 5 comments

it took me more then 2 mins and also more then 5 lines of code.

rycbar0 avatar Oct 13 '22 23:10 rycbar0

should i check if the player wears boots with frost walker enchantment? those also prevent damage from magma blocks without sneaking. if so should i allow pathfinding over magma allways or only when allowSneakOverMagma is true?

rycbar0 avatar Oct 18 '22 21:10 rycbar0

should i check if the player wears boots with frost walker enchantment? those also prevent damage from magma blocks without sneaking. if so should i allow pathfinding over magma allways or only when allowSneakOverMagma is true?

I'd say just treat magma as a harmless solid block without asking (or add yet another setting for it).

ZacSharp avatar Oct 19 '22 14:10 ZacSharp

i understand this that i should remove the allowSneakOverMagma setting and allways allow pathfinding over magma

rycbar0 avatar Oct 19 '22 14:10 rycbar0

i understand this that i should remove the allowSneakOverMagma setting and allways allow pathfinding over magma

Oh, sorry, that's my comment editing gone wrong. I originally intended to write something along the lines of "I'd say just use the boots without asking (or make it yet another setting)", but obviously I reworded that beyond repair. As long as it is reliable I don't see a need for a setting (it complicates things after all) and frostwalker boots are 100% reliable.

As for "allowSneakOverMagma": I personally don't care.

ZacSharp avatar Oct 19 '22 20:10 ZacSharp

Autoformatting caused quite a bunch of unrelated changes but ok. Code looks good to me now (apart from the todo comment).

It mostly sneaks way to much and not at all after parkour jumps onto magma.

https://user-images.githubusercontent.com/68165024/198906464-d94d19ee-8823-4b36-9593-d9dc5262f864.mp4

Do you think you could make it more like this (but without sneaking too little)?

https://user-images.githubusercontent.com/68165024/198906535-1ded1248-d6a1-48f1-9c1f-d5ad7fee77de.mp4

ZacSharp avatar Oct 30 '22 23:10 ZacSharp