baritone icon indicating copy to clipboard operation
baritone copied to clipboard

prevent non placable items causing issues in acceptable throwaway items.

Open wagyourtail opened this issue 3 years ago • 7 comments

fixes #3399

wagyourtail avatar Apr 17 '22 00:04 wagyourtail

Is it possible to expand this to all items which can't be walked on?

scorbett123 avatar Apr 17 '22 09:04 scorbett123

Is it possible to expand this to all items which can't be walked on?

Looking around for some candidates, Spider web and string are two obvious ones. I dont know how it handles things, but paintings, signs and item frames are worth considering, Maybe carpet.

XorOwl avatar Apr 17 '22 15:04 XorOwl

should I just check if the block it would place is canWalkOn or something? canWalkOn(bsi, x, y, z, item.getdefaultstate())?

wagyourtail avatar Apr 19 '22 05:04 wagyourtail

I'd say canWalkOn with a special case for isWater and isLava blocks (because those use the coordinates) is a good solution. If you find a way to do it without passing dummy arumgents that's better.

ZacSharp avatar Apr 19 '22 13:04 ZacSharp

I did a thing, does all now. does that look good?

wagyourtail avatar Apr 19 '22 22:04 wagyourtail

I did a thing, does all now. does that look good?

Looks good, but question, You removed import baritone.api.BaritoneAPI; from InventoryBehavior.java was that intentional? looks like it might have been an oopsie, but i'm not familiar enough with baritone's api to know for sure.

XorOwl avatar Apr 19 '22 23:04 XorOwl

my ide isn't showing any errors and it still builds, so the import was unused

wagyourtail avatar Apr 19 '22 23:04 wagyourtail