baritone icon indicating copy to clipboard operation
baritone copied to clipboard

Add only mining in of selections

Open scorbett123 opened this issue 3 years ago • 2 comments

Filter out any positions that aren't valid according to only mining inside selections, or only mining outside of selections.

I'm not really sure about the setting naming here, or even if this is the best way to do the settings, so any input on this would be appreciated.

partially fixes #3320 (this contains two suggestions) ~~fixes #2597~~ fixes #2249

~~This could also be seen as a fix for mining around "home" (#2054) however that could be made to work nicer~~

scorbett123 avatar Apr 11 '22 18:04 scorbett123

Looking at making this work for everything and per waypoint, maybe MovementHelper.avoidBreaking could go through all the waypoints with a tag "don't mine for X blocks from here", and return true if it is in any of those regions. However this is pretty likely to cause more lag.

I think mining only in a selection is something that you probably don't want to be persistent, as #2249 probably doesn't want it to be persistent, but out of selections should probably be persistent, using the waypoint system.

For now I'm going to remove the "onlyMineOutOfSelection" option, however I still think the onlyMineInSelection is a good addition.

scorbett123 avatar Apr 12 '22 10:04 scorbett123