svu icon indicating copy to clipboard operation
svu copied to clipboard

Published 20 hours ago • verified publisher icon caarlos0

Initial version does not work if pattern is supplied

Open jsok opened this issue 3 years ago • 1 comments

Effectively, if a pattern is supplied and no existing tags are found an error is always returned.

https://github.com/caarlos0/svu/blob/0b3a780f7a1f9bc57d27974cd61863b68deb6ca3/internal/git/git.go#L45-L54

Whereas if no pattern is supplied, it is not an error to find no tags:

https://github.com/caarlos0/svu/blob/0b3a780f7a1f9bc57d27974cd61863b68deb6ca3/internal/git/git.go#L38-L40

jsok avatar Jan 14 '22 00:01 jsok

I think this is quite useful when working inside monorepo. This PR https://github.com/caarlos0/svu/pull/57 looks promising. What needs to happen to have it implemented/fixed?

harnash avatar Aug 30 '23 13:08 harnash