datahub icon indicating copy to clipboard operation
datahub copied to clipboard

Normal_mixed_biopic 2021

Open stockschl opened this issue 1 year ago • 2 comments

#new pr for study Li et al., Nature 2021

checks

For all pull requests:

  • [ ] Passes validation

For a new study (in addition to above):

  • [ ] Does study name and study ID follow our convention? e.g. Tumor_Type (Institue, Journal Year); brca_mskcc_2015
  • [ ] is study meta data complete? e.g. pmid, group of PUBLIC
  • [ ] were all samples profiled with WES/WGS? If not, is gene panel file curated?
  • [ ] are oncotree codes of all samples curated; Cancer Type and Cancer Type Detailed needs to be added in addition to Oncotree Code
  • [ ] clinical sample and patient data with meta files
  • [ ] mutations data with meta files
  • [ ] MAF is based on hg19
  • [ ] MAF with 2 isoforms: uniprot and mskcc
  • [ ] CNA data with meta files
  • [ ] CNA segment data with meta files
  • [ ] Expression data including z-scores with meta files
  • [ ] Case-lists for all profiles.
  • [ ] Manual checking (Niki or JJ): Triage or private Portal link here

stockschl avatar Oct 24 '23 20:10 stockschl

Hi @stockschl, thanks for updating the PR! Everything looks great but I noticed a couple of minor errors:

  1. Study meta: OTHER is not a valid cancer type, can this be changed to 'mixed'?

  2. Sample file: The column (columns D, E, F) names (rows 1 & 2) in the sample file are mixed together and would need to be adjusted to match the attribute name.

  3. Case list: This study needs a 'cases_all' and 'cases_sequenced' files. The case list file needs to be fixed, please see here.

Thank you!

Rima-Waleed avatar Nov 01 '23 13:11 Rima-Waleed

Hi @Rima-Waleed,

made all the changes requested. Thank you!

stockschl avatar Nov 01 '23 19:11 stockschl