cbioportal icon indicating copy to clipboard operation
cbioportal copied to clipboard

improve patient page with multiple samples and one is not profiled

Open tmazor opened this issue 2 years ago • 2 comments

This is a patient with 2 samples. One sample is profiled for Mut & CNA, while the other sample has not been profiled. https://www.cbioportal.org/patient/summary?studyId=mpcproject_broad_2021&caseId=MPCPROJECT_0013 image

In #9708 I asked that we improve the sample & patient pages for when a patient/sample aren't profiled. That's now in the works and fixes things when looking at an unprofiled sample or a patient when all samples are unprofiled.

However, looking at the patient page when there's a mix of profiled and unprofiled samples (as in the patient linked above) is still misleading. It shows all the data from the profiled sample, but there's no indication that the other sample was not profiled, which may leave a user to interpret that sample as being profiled but just not having alterations.

I'm not entirely sure what the best solution to this is. My initial thought is a message attached to each table to say 'Sample XXX is not profiled for Mutations/CNA/SV'. But I'd be very open to other suggestions!

tmazor avatar Sep 19 '22 18:09 tmazor

@tmazor maybe we merge this and then address the above in a new issue/PR?

alisman avatar Sep 21 '22 15:09 alisman

Oh for sure! Sorry I wasn't clear @alisman - I definitely meant for this new ticket to be dealt with in a new PR.

tmazor avatar Sep 21 '22 21:09 tmazor