cbioportal icon indicating copy to clipboard operation
cbioportal copied to clipboard

Move OncoKB Card and icon as a separate packages

Open zhx828 opened this issue 2 years ago • 0 comments

MPath mentioned that they can use the OncoKB card component if it's an independent package. We can also make OncoKB icon(compact/full) in the annotation column as a separate package and depends on OncoKB card. Currently both of the components are under react-mutation-mapper.

To-do list:

  • [x] Create a oncokb-frontend-commons folder, similar to cbioportal-frontend-commons
  • [x] Move OncoKBCard out of react-mutation-mapper into the new package
  • [ ] Make sure Lerna is working properly to auto-publish the package
  • [ ] Move OncoKB icons into the new package

Notes:

  1. These components should be functional components, meaning Mobx should not be the dependency. Using react hooks for changing the states
  2. You can import some of the dependencies from main repo even without specifying in oncokb-frontend-commons package.json But this needs to be carefully planned/reviewed. We should not use any libraries that not in the oncokb-frontend-commons package.json

zhx828 avatar Jun 15 '22 02:06 zhx828