cbioportal icon indicating copy to clipboard operation
cbioportal copied to clipboard

Update swagger.config and Replace _ with - in all generic assay API endpoints and its usages

Open jagnathan opened this issue 2 years ago • 2 comments

Update swagger.config to include GENE_PANEL_DATA in public APIs

Replace _ with - in all generic assay API endpoints and its usages Related to #9433

Additional end points where underscore has to be changed to hyphen (dash). "/virtual_study" "/virtual_study/save" "/custom_data/fetch" "/custom_gene_list/save" "/custom_gene_list" Frontend and backend changes have to happen together.

Backend changes

  • [x] web/src/main/java/org/cbioportal/web/config/SwaggerConfig.java
  • [x] web/src/main/java/org/cbioportal/web/GenericAssayController.java
  • [x] web/src/main/java/org/cbioportal/web/GenericAssayDataController.java
  • [x] web/src/test/java/org/cbioportal/web/GenericAssayControllerTest.java
  • [x] web/src/test/java/org/cbioportal/web/GenericAssayDataControllerTest.java
  • [x] Add redirects for old routes ~- [ ] org/cbioportal/web/SessionServiceController.java~ ~- [ ] Add redirects for old routes of SessionServiceController~
  • [ ] Notify r slack users

Frontend changes

jagnathan avatar Jun 03 '22 18:06 jagnathan

Additional end points where underscore has to be changed to hyphen (dash). "/virtual_study" "/virtual_study/save" "/custom_data/fetch" "/custom_gene_list/save" "/custom_gene_list" Frontend and backend changes have to happen together.

These endpoints are dependent on types in Session Service. This means that the types in Session service have to change from virtual_study to virtual-study.

@RequestMapping(value = "/{type:virtual_study|group|custom_data|custom_gene_list}/{operation}/{id}", method = RequestMethod.GE

jagnathan avatar Jun 09 '22 16:06 jagnathan

The redirect works including POST. CircleCI does not accept redirects while testing. Changes to the frontend are in progress.

jagnathan avatar Jul 25 '22 18:07 jagnathan

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 29 '22 11:10 stale[bot]