cbioportal icon indicating copy to clipboard operation
cbioportal copied to clipboard

remove unneeded references to old tables

Open sheridancbio opened this issue 7 months ago • 1 comments

Describe changes proposed in this pull request:

  • tables pdb_uniprot_alignment and pdb_uniprot_residue_mapping were removed at db version 2.12.12 there is no need to refer to them in cgds.sql or cgds-h2.sql
  • whitespace standardization in migration.sql

These changes should have no semantic effect. When installing a new database schema there is no need to purge tables which should not be present and are not created.

Checks

  • [ ] The commit log is comprehensible. It follows 7 rules of great commit messages. We can fix this during merge by using a squash+merge if necessary
  • [ ] Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • [ ] Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!
  • [ ] Make sure your PR has one of the labels defined in https://github.com/cBioPortal/cbioportal/blob/master/.github/release-drafter.yml

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging policy. It can help to figure out who worked on the file before you. Please use git blame <filename> to determine that and notify them either through slack or by assigning them as a reviewer on the PR

sheridancbio avatar Jun 28 '24 21:06 sheridancbio