cbioportal-frontend icon indicating copy to clipboard operation
cbioportal-frontend copied to clipboard

Implement RFC85 Dynamic Virtual Study

Open forus opened this issue 1 year ago • 2 comments

Fix cBioPortal/cbioportal# (see https://help.github.com/en/articles/closing-issues-using-keywords)

Describe changes proposed in this pull request:

  • Added option to select a dynamic type of virtual study while creating it
  • Static type (the legacy one) is the default one

Checks

  • [ ] Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • [ ] The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • [ ] Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging policy. It can help to figure out who worked on the file before you. Please use git blame <filename> to determine that and notify them either through slack or by assigning them as a reviewer on the PR

forus avatar Oct 02 '24 15:10 forus

Deploy Preview for cbioportalfrontend ready!

Name Link
Latest commit 16102dcaae5d3b0f5d34e6b74075880a6b576d42
Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/673f75a295d7cc00089566a4
Deploy Preview https://deploy-preview-5016.cancerrevue.org
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 02 '24 15:10 netlify[bot]

@alisman @haynescd @pieterlukasse I've changed code to provide different descriptions for static and dynamic Virtual Study by default. Check https://github.com/cBioPortal/cbioportal-frontend/pull/5016/commits/4b49f4fb01a94fb39bd9aea00bc0c74338ced210

forus avatar Oct 23 '24 17:10 forus