cbioportal-frontend
cbioportal-frontend copied to clipboard
Display geneUI on Row Hover Instead of geneSymbol Hover
Solving issue #10762
Summary
This PR modifies the behavior of the geneUI component, ensuring it is displayed only when hovering over the entire row (.row) rather than just the geneSymbol element. This change enhances the user experience by making the geneUI visibility consistent across the entire row.
Changes Made
-
CSS Adjustments:
- Moved the hover effect for displaying
.addGeneUIfrom.geneSymbol:hoverto.row:hover. - Removed the previous hover effect on
.geneSymbolthat controlled the visibility of.addGeneUI.
- Moved the hover effect for displaying
-
Updated Selectors:
- Applied the
%addGeneUIHovermixin to.addGeneUIwithin the.row:hovercontext.
- Applied the
Issue Resolution
The issue was resolved by ensuring the geneUI component becomes visible only when hovering over the .row element, rather than when hovering over the .geneSymbol element. This change required adjusting the CSS selectors and hover states to target the entire row.
Related Issue
Testing and Verification
- Verified that the
geneUIappears when hovering over any part of the row and not just thegeneSymbol. - Confirmed that the
geneUImaintains proper styling and functionality when hovered and selected.
Please review the changes and let me know if any further adjustments are needed.
Deploy Preview for cbioportalfrontend ready!
| Name | Link |
|---|---|
| Latest commit | 4da92c17efb30af0be1f48fe3466f633b919213d |
| Latest deploy log | https://app.netlify.com/sites/cbioportalfrontend/deploys/66a87a8709f297000872a959 |
| Deploy Preview | https://deploy-preview-4954--cbioportalfrontend.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
This was addressed in https://github.com/cBioPortal/cbioportal-frontend/pull/5059 Thank for your your submission