cbioportal-frontend icon indicating copy to clipboard operation
cbioportal-frontend copied to clipboard

Group comparison view: update boxplot info in clinical tab

Open TJMKuijpers opened this issue 1 year ago • 5 comments

In the group comparison view, when we go to the clinical tab there is the option to show different clinical attributes per group. Those clinical attributes are either visualized as a stacked bar chart or boxplot.

The figure with the boxplot shows a boxplot with all samples as scatter points. image

When we set the visualization type to table, we can see that only the boxplot information is shown: image

This is quite confusing for the user since the minimum and maximum values are the lower and upper whisker of the boxplot, not of the data points. We should add this information but also add to the current table that these numbers are describing the boxplot.

This would be the proposed solution (image created with test study es_0) image

TJMKuijpers avatar Jun 14 '24 09:06 TJMKuijpers

Deploy Preview for cbioportalfrontend ready!

Name Link
Latest commit 9ec42f588e216a396ac9f434acac01dae9b2baaa
Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/674dd03cb290cf00089ed522
Deploy Preview https://deploy-preview-4924.cancerrevue.org
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 14 '24 09:06 netlify[bot]

@inodb in the third image: I'm not sure what the standard is --> should boxplot (and scatterplot) be one or two words. It seems that both are used when I do a quick google search.

TJMKuijpers avatar Jun 17 '24 14:06 TJMKuijpers

@TJMKuijpers Good catch! Thanks for trying to come up with a solution to this

I think the "Table" name here is unintuitive. How about we call it "Summary Statistics"?

In the "Summary Statistics" maybe better to not put the words 'boxplot' nor 'scatterplot'. E.g. imagine sharing a link to this table directly. It's unclear what's meant by scatterplot/boxplot. The boxplot stats are already shown as a tooltip on the boxplot itself. It might be better to only show summary statistics similar to e.g. what the R package does here: https://www.reneshbedre.com/blog/describe-function-in-r.html. So just general data stats (i.e. the scatterplot table) and maybe a few others that the R package reports

Does that make sense?

inodb avatar Jun 19 '24 15:06 inodb

@inodb I updated the table to match the descriptive information Pandas or R returns: image

Table will be updated when the user clicks on "log scale': image image

TJMKuijpers avatar Jun 24 '24 10:06 TJMKuijpers

@inodb and @dippindots could you have a look at this PR?

TJMKuijpers avatar Jul 08 '24 14:07 TJMKuijpers