cbioportal-frontend icon indicating copy to clipboard operation
cbioportal-frontend copied to clipboard

RFC83: Make virtual study available for all users on their landing pages

Open forus opened this issue 1 year ago • 2 comments

Fix cBioPortal/cbioportal# (see https://help.github.com/en/articles/closing-issues-using-keywords)

Describe changes proposed in this pull request:

  • Introduce an admin call, secured by a secret key, to publish virtual studies for all users, making them visible on the landing page.

Backend https://github.com/cBioPortal/cbioportal/pull/10829

Checks

  • [ ] Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • [x] The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • [x] Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging policy. It can help to figure out who worked on the file before you. Please use git blame <filename> to determine that and notify them either through slack or by assigning them as a reviewer on the PR

forus avatar Jun 13 '24 15:06 forus

Deploy Preview for cbioportalfrontend ready!

Name Link
Latest commit c3ef88daf0f4e4d6925e6f460b91e5aabb8d77f7
Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/669921f63e9f5e000840626d
Deploy Preview https://deploy-preview-4923--cbioportalfrontend.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 13 '24 15:06 netlify[bot]

@alisman Hi! Could you please provide some guidance on which tests I should write for this PR?

forus avatar Jun 21 '24 08:06 forus