cbioportal-frontend icon indicating copy to clipboard operation
cbioportal-frontend copied to clipboard

move sync to async on remote/customTab.spec.js

Open bemijonathan opened this issue 1 year ago • 9 comments

Fix cBioPortal/cbioportal# (see https://help.github.com/en/articles/closing-issues-using-keywords)

Describe changes proposed in this pull request:

  • move test cases from sync to async on remote/customTab.spec.js

Checks

  • [x] Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • [x] The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • [ ] Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging policy. It can help to figure out who worked on the file before you. Please use git blame <filename> to determine that and notify them either through slack or by assigning them as a reviewer on the PR

bemijonathan avatar Jun 06 '24 15:06 bemijonathan

Deploy Preview for cbioportalfrontend ready!

Name Link
Latest commit 1adafeecf1fed5a1eb1040cd351b1b027f851645
Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/6697f00f4ab0900008a03f0e
Deploy Preview https://deploy-preview-4920--cbioportalfrontend.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 06 '24 15:06 netlify[bot]

Screenshot 2024-06-12 at 20 55 37

bemijonathan avatar Jun 12 '24 19:06 bemijonathan

Screenshot 2024-06-12 at 21 10 49

for some reason this test does not pass with all pancan, expression NOT available

bemijonathan avatar Jun 12 '24 20:06 bemijonathan

Screenshot 2024-06-12 at 21 28 03

bemijonathan avatar Jun 12 '24 20:06 bemijonathan

Screenshot 2024-06-12 at 21 31 46

bemijonathan avatar Jun 12 '24 20:06 bemijonathan

Screenshot 2024-06-12 at 22 56 51

bemijonathan avatar Jun 12 '24 21:06 bemijonathan

Screenshot 2024-06-12 at 23 01 32

bemijonathan avatar Jun 12 '24 22:06 bemijonathan

Screenshot 2024-06-12 at 23 09 42

bemijonathan avatar Jun 12 '24 22:06 bemijonathan

Screenshot 2024-06-12 at 23 38 10

bemijonathan avatar Jun 12 '24 22:06 bemijonathan