cbioportal-frontend icon indicating copy to clipboard operation
cbioportal-frontend copied to clipboard

Refactor StudyViewPageStore

Open alisman opened this issue 10 months ago • 2 comments

Fix cBioPortal/cbioportal# (see https://help.github.com/en/articles/closing-issues-using-keywords)

Describe changes proposed in this pull request:

  • a
  • b

Checks

  • [ ] Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • [ ] The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • [ ] Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging policy. It can help to figure out who worked on the file before you. Please use git blame <filename> to determine that and notify them either through slack or by assigning them as a reviewer on the PR

alisman avatar Mar 27 '24 15:03 alisman

Deploy Preview for cbioportalfrontend ready!

Name Link
Latest commit 5d2763654a3f5527d3d2993a457cd7c19e15bbd8
Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/66043552ccf117000875d647
Deploy Preview https://deploy-preview-4881--cbioportalfrontend.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 27 '24 15:03 netlify[bot]

@haynescd to continue this

inodb avatar Apr 11 '24 14:04 inodb