bbgo icon indicating copy to clipboard operation
bbgo copied to clipboard

add new tag ignore to prevent printing specific field

Open lanphan opened this issue 1 year ago • 6 comments

lanphan avatar Sep 13 '24 12:09 lanphan

Welcome back! @lanphan, This pull request may get 213 BBG.

bbgokarma-bot avatar Sep 13 '24 12:09 bbgokarma-bot

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 24.02%. Comparing base (336dd7a) to head (dad7b53). Report is 224 commits behind head on main.

Files with missing lines Patch % Lines
pkg/dynamic/print_config.go 0.00% 4 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1743      +/-   ##
==========================================
- Coverage   24.11%   24.02%   -0.10%     
==========================================
  Files         615      623       +8     
  Lines       37447    38025     +578     
==========================================
+ Hits         9031     9135     +104     
- Misses      27621    28091     +470     
- Partials      795      799       +4     
Files with missing lines Coverage Δ
pkg/dynamic/print_config.go 0.00% <0.00%> (ø)

... and 29 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25a2203...dad7b53. Read the comment docs.

codecov[bot] avatar Sep 13 '24 13:09 codecov[bot]

Re-estimated karma: this pull request may get 243 BBG

bbgokarma-bot avatar Sep 14 '24 15:09 bbgokarma-bot

@c9s you want to change field name to ignore: true to be consistent with printdump as Railgun said? He already has PR to add documentation for that

lanphan avatar Sep 20 '24 13:09 lanphan

Re-estimated karma: this pull request may get 251 BBG

bbgokarma-bot avatar Oct 02 '24 16:10 bbgokarma-bot

@c9s I update tag name to "ignore", so that it's consistent with document https://github.com/c9s/bbgo/blob/main/doc/topics/rw-strategy.md

lanphan avatar Oct 02 '24 16:10 lanphan

Hi @lanphan,

Well done! 261 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x9c0d8a0721470e24ee5ab8a13c198987f776606aa31094b6febabcf37bbeaf37

Thank you for your contribution!

bbgokarma-bot avatar Oct 28 '24 13:10 bbgokarma-bot