logseq-hypothesis icon indicating copy to clipboard operation
logseq-hypothesis copied to clipboard

Notes are not created as child blocks

Open krillin666 opened this issue 3 years ago • 5 comments

Hi @c6p, thank you for this amazing plugin !

I've noticed one bug since the last update. When I have a highlight that has a comment, when it gets imported to Logseq I expect it to have the following format:

- > An highlight
    - A commentary 

So basically, that any commentary gets added to the respective highlight under its child block

However, what I get is all in one block:

- An highlight
A commentary

Thank you for your time !

krillin666 avatar May 25 '22 10:05 krillin666

Hey @krillin666,

Annotations are placed within the same block, while replies are children.

resim

- It focuses on privacy, longevity
Annotation
  - Reply

Is your commentary an annotation or a reply in hypothes.is terms? If it is an annotation, the current behavior is correct. Though, in the future, I may add custom behavior where annotation is also a child of a highlight.

- It focuses on privacy, longevity
  - Annotation
    - Reply

c6p avatar May 25 '22 13:05 c6p

I'm sorry, I thought this was a bug. Then I think this issue might be turned into a feature request :sweat_smile: ?

krillin666 avatar May 25 '22 14:05 krillin666

Come to think of it, hypothesis does not make any distinction between a highlight and an annotation. Returning it in the same row with a single ID. Placing an annotation into another block in Logseq, would make tracking it impossible. So, it won't be fixed. Sorry, @krillin666.

You can modify the templates to make it visually more distinct, though.

Is there anything I could do, to make the current behavior more bearable?

Cheers

c6p avatar May 26 '22 13:05 c6p

Come to think of it, hypothesis does not make any distinction between a highlight and an annotation. Returning it in the same row with a single ID. Placing an annotation into another block in Logseq, would make tracking it impossible. So, it won't be fixed. Sorry, @krillin666.

You can modify the templates to make it visually more distinct, though.

Is there anything I could do, to make the current behavior more bearable?

Cheers

Actually, there is ! Is it possible to add a vertical space (shift+enter) in the block when we have highlight+annotation ? Because, what is happening now is that since there's no space between the highlight and the annotation, the annotation gets blended and rendered has a highlight.

Basically, this is what's happening:

> It focuses on privacy, longevity
Annotation

And so that Annotation is not rendered has a highlight due to the settings having > before the highlight, I have to manually add a shift+enter vertical space like this:

> It focuses on privacy, longevity

Annotation

Thank you for your time !

krillin666 avatar May 26 '22 21:05 krillin666

You are right, I'm going to add a line break before annotation in the next version.

c6p avatar May 27 '22 12:05 c6p

@yhkang, from now on, you can use \n in annotation formats to add newlines where you want.

c6p avatar Dec 28 '22 11:12 c6p