bump2version icon indicating copy to clipboard operation
bump2version copied to clipboard

Load cli args before config file

Open ecs-jnguyen opened this issue 4 years ago • 1 comments

Description

Hi I'm opening this PR to address this issue: https://github.com/c4urself/bump2version/issues/231

I am modifying the configuration loading piece of bump2version so that the cli arguments take precedence over the configurations in the file.

Behavior before pull request Example

Step 1 create .bumpversion.cfg and version.txt

.bumpversion.cfg

[bumpversion]
current_version = 0.8.0
serialize = {major}.{minor}
parse = (?P<major>\d+)\.(?P<minor>\d+)(\.(?P<patch>\d+))?

[bumpversion:file:version.txt]

version.txt:

0.8.0

Run bump2version

$ bump2version patch --serialize "{major}.{minor}.{patch}" --list
current_version=0.8.0
serialize={major}.{minor}
parse=(?P<major>\d+)\.(?P<minor>\d+)(\.(?P<patch>\d+))?
new_version=0.8.1

Results

  • .bumpversion.cfg == 0.8.1
  • version.txt == 0.8

Behavior after changes

[bumpversion]
current_version = 0.8.0
serialize = {major}.{minor}
parse = (?P<major>\d+)\.(?P<minor>\d+)(\.(?P<patch>\d+))?

[bumpversion:file:version.txt]

version.txt:

0.8.0

Run bump2version

$ bump2version patch --serialize "{major}.{minor}.{patch}" --list
current_version=0.8.0
serialize={major}.{minor}
parse=(?P<major>\d+)\.(?P<minor>\d+)(\.(?P<patch>\d+))?
new_version=0.8.1

Results

  • .bumpversion.cfg == 0.8.1
  • version.txt == 0.8.1

ecs-jnguyen avatar Aug 20 '21 21:08 ecs-jnguyen

I think this makes sense... We can consider it for the next release.

florisla avatar Oct 15 '21 07:10 florisla