deno-cliffy icon indicating copy to clipboard operation
deno-cliffy copied to clipboard

feat: add support for `jsr` repository

Open JOTSR opened this issue 11 months ago • 4 comments

Summary

Add support for jsr repository.

Motivation

Allow use of cliffy in jsr packages.

Changes

  • Replace all remote url imports by jsr or npm imports.
  • Add package metadatas (name and version need to be approved/updated).
  • Fix all slow types.
  • Upgrade deno/std to 0.217.
  • Add jsr publish workflow

JOTSR avatar Feb 29 '24 12:02 JOTSR

deno publish --dry-run failed to resolve types imported in @cliffy/command/type.ts. Maybe I can use a temp patch if the bug persist and is not resolved before PR merge. (reported on @denoland/deno#22819)

JOTSR avatar Mar 09 '24 00:03 JOTSR

Deno 1.41.3 was just released and fix denoland/deno#22819 so cliffy is now ready for jsr. I made a last commit to run deno fmt and harmonize source code to continue from an fresh base.

JOTSR avatar Mar 14 '24 21:03 JOTSR

There seems to be an issue with the snapshotTest method. The "deno run" command, which is called in the snapshotTest method, does not automatically load the deno config from the current working directory and does not resolve the imports correctly. It only works if I explicitly add the config to the command.

c4spar avatar Mar 17 '24 23:03 c4spar

There seems to be an issue with the snapshotTest method. The "deno run" command, which is called in the snapshotTest method, does not automatically load the deno config from the current working directory and does not resolve the imports correctly. It only works if I explicitly add the config to the command.

Yeah I missed tests fails because I was running it wrongly and so I always see some fails. Now it's fixed, It's only from snapshot.ts I force config in the Deno.Command.

JOTSR avatar Mar 18 '24 16:03 JOTSR