Benjamin Fischer

Results 64 comments of Benjamin Fischer

I think if we adjust the boolean type to always be a boolean, we should also adjust collectible options to always be an array. Feel free to open a PR,...

I'm willing to reconsider the defaults, but I'd like to hear more feedback from more people first. I have created an issue for this #552.

I will close this PR now. I made the input and output configurable but i will keep stdout the default. But thx for your PR @crooke! Feel free to open...

Normally this should happen automatically. Looks like GitHub actions has a hickup. Maybe try to push something and then revert it.

thx @annervisser! i will merge it when i prepare the 1.0 release.

@annervisser, i noticed we could also implement this without a breaking change by using a try catch block and checking for a `PermissionDenied` error. What do you think?

Sry for late reply! Yes, i already had this in mind. My plan was to expose the `execute` method and add an `execute` option to the parse method to skip...

Hi @johnstonmatt, I'm glad to hear that! Sounds reasonable to make the exitCode configurable. Should we make a distinction between missing or invalid values? We could also set the exitCode...

Thank you for your thoughts @chmac! > How would this interact with dot values like .option("-f.b --foo-bar ")? Would the equivalent env var be FOO.BAR? That's a good question. I...

I think we can remove the default value for the main option for now. I am currently working on a refactoring of the upgrade command and may move the default...