Claire Foster comments

Results 774 comments of


                                            Claire Foster

`import as if`

On further consideration, I do agree that this is confusing, and ideally could be deprecated in future as a warning, then an error. The amount of breaking would need to...

support for for-else and while-else

Heya, we just moved JuliaSyntax into Base in https://github.com/JuliaLang/julia/pull/59870 - if you want to re-propose this PR over there, I've created a branch https://github.com/JuliaLang/JuliaSyntax.jl/tree/pr-for-Base/513 to make this easier. To make...

Separate out "trivia" from "notation"

I think it could be nice to do *something* here ... but I'm not sure what it should be. For example, even comments can act as semantic whitespace: ``` julia>...

Separate out "trivia" from "notation"

The general approach of `JuliaSyntaxFormatter` is to emit a stream of tokens including the semantic whitespace as "flexible space". Then later run a heuristic formatting pass which decides what each...

`parse_brackets` should probably specialize on the function

The least invasive fix could be the type assert of opts I mentioned in #615, if that works?

`parse_brackets` should probably specialize on the function

Thanks for the detailed description of the invalidations btw, I do love to see it :)

Newline macros

Interpolated `getproperty` syntax error

This error arises from lowering, it's not really a JuliaSyntax issue: ```julia julia> (101im).:($(:im)) 101 julia> (101im).:($(Symbol("im"))) ERROR: syntax: invalid syntax "(101 * im).(Symbol("im"))" around REPL[25]:1 Stacktrace: [1] top-level scope...

Type-assert `opts.delim_flags` to reduce invalidations

Thanks James sorry for the bother. Ideally I'd like to never release code out of this repo again, but if it's most expedient to do so for the purposes of...