c3y1huang

Results 29 comments of c3y1huang

Test result (full): - Talos (v1.5.5) - S3 ``` = 336 passed, 18 skipped, 223 warnings in 50413.40s (14:00:13) = ``` - NFS ``` = 335 passed, 19 skipped, 246...

I am thinking if we can make this more intuitive by having a list for `recurringJobs`. Each item could have customizable values matching the RecurringJob spec. ``` recurringJobs: - name:...

I see. Creating RecurringJob and associating with a group sounds like a logical approach. However, I'm not entirely clear on the need to create a separate StorageClass when the groups...

Got it. However, I think it would be better not to include the creation of the StorageClass in the `recurringJob`, as there are other fields and parameters to consider and...

I like the volumeGroups approach. What do you think of re-arrange like below? ```yaml volumeGroups: recurringJobDefaults: concurrency: 4 retain: 1 spreadCronStartTimes: true minuteStep: 5 hourStep: 2 storageClassDefaults: provisioner: driver.longhorn.io allowVolumeExpansion:...

Having this could simplify the management when the user is managing volumes with multiple StorageClasses. However, we should also take into account how this fits with the volume group concept...

Proactively mitigating the risk of data loss from potential backup gaps sounds fair to me.

@jillian-maroket , this doc has been [tested by @yangchiu](https://github.com/longhorn/longhorn/issues/6165#issuecomment-2078678700) and should be ready for merge. Would you give it a final review?

> @c3y1huang Let me know if you have concerns about the changes. LGTM, thank you.